Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go all in with uv #67

Merged
merged 17 commits into from
Mar 9, 2025
Merged

Go all in with uv #67

merged 17 commits into from
Mar 9, 2025

Conversation

stevepiercy
Copy link
Contributor

@stevepiercy stevepiercy commented Mar 8, 2025

  • Manage requirements
  • Update Makefile commands
  • Update contribute.md documentation

@Manas-Kenge would you please check out this branch, and try it out?

The biggest change is how to install uv and no longer manually installing a modern Python, since uv handles it for you. You will need to install uv first as described in https://docs.astral.sh/uv/getting-started/installation/#standalone-installer


📚 Documentation preview 📚: https://plone-sphinx-theme--67.org.readthedocs.build/

- Manage requirements
- Update Makefile commands
- Update contribute.md documentation
@stevepiercy stevepiercy requested review from davisagli and ericof March 8, 2025 10:35
@stevepiercy stevepiercy requested a review from ksuess March 8, 2025 11:37
Copy link

@rohnsha0 rohnsha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Manas-Kenge
Copy link
Contributor

Manas-Kenge commented Mar 9, 2025

@stevepiercy Do you think removing Python support completely is a good idea? Wouldn't it be better to support both for now? Moving to uv might be hard for newcomers, so keeping Python support could make the switch easier.

@stevepiercy
Copy link
Contributor Author

@Manas-Kenge from the uv docs:

https://docs.astral.sh/uv/guides/install-python/

If Python is already installed on your system, uv will detect and use it without configuration. However, uv can also install and manage Python versions. uv automatically installs missing Python versions as needed — you don't need to install Python to get started.

@stevepiercy
Copy link
Contributor Author

Hm, the 3.10 job used 3.13. That's not good. Let's try something else.

@stevepiercy
Copy link
Contributor Author

Oh, duh. make dev overrides the Python 3.10 installed via matrix.python-version. Rats.

Actually, I think I know a trick I can use to allow passing in a value for make dev python-version, with a default fallback. Let's give that a try. 🧑‍🔬

@stevepiercy stevepiercy merged commit c069fca into main Mar 9, 2025
5 checks passed
@stevepiercy stevepiercy deleted the uv-all-in branch March 9, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants