Fix query string parsing regression introduced in 2.18.2 #3106 #3341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix query string parsing regression introduced in 2.18.2
This PR fixes a regression introduced in Dash 2.18.2 where query string values containing unencoded
&
characters were being truncated at the first&
.Problem: In 2.18.2,
?param1=something&bla¶m2=something2
would result inparam1='something'
instead of the expectedparam1='something&bla'
from 2.18.1.Root Cause: The automatic URL decoding feature from #2991 caused
unquote()
to decode%26
to&
, whichparse_qs()
then misinterpreted as parameter delimiters.Solution: Remove the automatic
unquote()
call to restore 2.18.1 behavior while maintaining support for properly encoded URLs.Fixes #3106
Contributor Checklist
CHANGELOG.md
Changes Made