fix of issues from klocwork and coverity

examples/segment_vector/segment_vector.cpp

@@ -63,7 +63,7 @@ main(int argc, char *argv[])
  try {
  pop = pool<root>::open(path, "segment_vector_example");
  r = pop.root();
- } catch (const pmem::pool_error &e) {
+ } catch (const std::exception &e) {
  std::cerr << "Exception: " << e.what() << std::endl;
  return 1;
  }

include/libpmemobj++/container/concurrent_hash_map.hpp

@@ -1737,6 +1737,11 @@ class concurrent_hash_map
  acquire(base, h, writer);
  }
 
+ bucket_accessor(const bucket_accessor &other) = delete;
+
+ bucket_accessor &
+ operator=(const bucket_accessor &other) = delete;
+
  /**
  * Find a bucket by masked hashcode, optionally rehash, and
  * acquire the lock

include/libpmemobj++/container/detail/concurrent_skip_list_impl.hpp

@@ -358,6 +358,13 @@ class skip_list_iterator {
  return tmp;
  }
 
+ skip_list_iterator &
+ operator=(const skip_list_iterator &other)
+ {
+ node = other.node;
+ return *this;
+ }
+
 private:
  explicit skip_list_iterator(node_type *n) : node(n)
  {

tests/enumerable_thread_specific_ctor/enumerable_thread_specific_ctor.cpp

@@ -44,7 +44,7 @@ test(int argc, char *argv[])
  parallel_exec(concurrency, [&](size_t thread_index) {
  r->pptr1->local() = thread_index;
  pop.persist(&r->pptr1->local(),
- sizeof(&r->pptr1->local()));
+ sizeof(r->pptr1->local()));
  });
 
  nvobj::transaction::run(pop, [&] {

tests/inline_string/inline_string.cpp

@@ -26,6 +26,8 @@ struct Object {
 
  Object(const Object &o) = default;
 
+ Object &operator=(const Object &o) = default;
+
  nvobj::p<int> data;
  nvobj::experimental::inline_string s;
 };

tests/pair/pair.cpp

@@ -34,6 +34,8 @@ struct A {
  c = rhs.c;
  }
 
+ A &operator=(const A &) = default;
+
  int a;
  int b;
  int c;

tests/ptr_arith/ptr_arith.hpp

@@ -102,7 +102,7 @@ test_arith(nvobj::pool_base &pop)
  for (int i = TEST_ARR_SIZE; i > 0; --i)
  UT_ASSERTeq(*(parr_end - i), TEST_ARR_SIZE - i);
 
- UT_OUT("%d", parr_end - parr_vsize);
+ UT_OUT("%ld", parr_end - parr_vsize);
  UT_ASSERTeq(parr_end - parr_vsize, TEST_ARR_SIZE);
 
  /* check ostream operator */

tests/volatile_state/volatile_state.cpp

@@ -30,6 +30,8 @@ struct v_data1 {
 
  v_data1(const v_data1 &rhs) = delete;
 
+ v_data1 &operator=(const v_data1 &rhs) = delete;
+
  ~v_data1()
  {
  volatile_object_state = volatile_object_state_type::destroyed;