Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix top banner ad position is leaving a wide gap #237

Merged
merged 6 commits into from
Sep 2, 2024

Conversation

gumaciel
Copy link
Contributor

@gumaciel gumaciel commented Sep 2, 2024

Apparently, when Godot is in immersive mode, it continues to calculate the Safe Area unnecessarily, a validation was added to check if Godot is in immersive_mode

Resolution

Without immersive_mode enabled:

immersive_mode1

With immersive_mode enabled:

immersive_mode2

@gumaciel gumaciel linked an issue Sep 2, 2024 that may be closed by this pull request
@gumaciel gumaciel merged commit e8a0ef5 into master Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TOP Banner Ad position is leaving a wide gap
1 participant