Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move Parquet deserialization to BitmapBuilder #20896

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

coastalwhite
Copy link
Collaborator

follow up for #20714.

@coastalwhite coastalwhite marked this pull request as draft January 24, 2025 16:04
@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Jan 24, 2025
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 37.42331% with 102 lines in your changes missing coverage. Please review.

Project coverage is 79.31%. Comparing base (176268e) to head (c7a0e3b).
Report is 58 commits behind head on main.

Files with missing lines Patch % Lines
...w/read/deserialize/dictionary_encoded/predicate.rs 0.00% 63 Missing ⚠️
...et/src/arrow/read/deserialize/binview/predicate.rs 0.00% 13 Missing ⚠️
...rrow/read/deserialize/primitive/plain/predicate.rs 0.00% 9 Missing ⚠️
...lars-parquet/src/arrow/read/deserialize/boolean.rs 53.33% 7 Missing ⚠️
.../src/arrow/read/deserialize/primitive/plain/mod.rs 50.00% 6 Missing ⚠️
...-parquet/src/arrow/read/deserialize/binview/mod.rs 66.66% 2 Missing ⚠️
...rs-parquet/src/arrow/read/deserialize/utils/mod.rs 80.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20896   +/-   ##
=======================================
  Coverage   79.30%   79.31%           
=======================================
  Files        1578     1578           
  Lines      224109   224089   -20     
  Branches     2574     2574           
=======================================
- Hits       177728   177725    -3     
+ Misses      45790    45773   -17     
  Partials      591      591           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coastalwhite coastalwhite force-pushed the refactor/bitmap-builder-parquet branch from 686e6e1 to 5ce1243 Compare January 27, 2025 08:16
@coastalwhite coastalwhite marked this pull request as ready for review January 27, 2025 08:16
@coastalwhite coastalwhite marked this pull request as draft January 27, 2025 09:41
@coastalwhite

This comment was marked as resolved.

@coastalwhite coastalwhite marked this pull request as ready for review January 27, 2025 15:22
@ritchie46 ritchie46 merged commit 4f67546 into pola-rs:main Jan 28, 2025
22 checks passed
@c-peters c-peters added the accepted Ready for implementation label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants