-
Notifications
You must be signed in to change notification settings - Fork 32
attr -> pydantic #154
attr -> pydantic #154
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
==========================================
+ Coverage 99.28% 99.44% +0.16%
==========================================
Files 12 11 -1
Lines 837 898 +61
==========================================
+ Hits 831 893 +62
+ Misses 6 5 -1 ☔ View full report in Codecov by Sentry. |
Oh I love this idea! I think it makes a ton of sense. Cannot look into the code just yet but ping me again when the CI is green |
What's your decision on typing? If we're using Self and StrEnum then we're limited to Python 3.11+ (see my original post). |
Aren't there backports in |
Python 3.7 support has been dropped as Pydantic>=2.10.0 doesn't support it. |
Good for me, 3.7 is EOL anyway. So is 3.8, by the way. Let's drop both. I see you replaced |
Python 3.8 dropped. pydantic doesn't work with Want to drop Python 3.9 or implement |
Hm interesting. Well, let's drop Python 3.9 then! |
All checks passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Replace attrs with pydantic.
@astrojuanlu Let me know your thoughts.