Refine activation events #286
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisVaughan
commented
Mar 15, 2025
| @@ -7,6 +7,8 @@ | |||
|
|
|||
| ## Development version | |||
|
|
|||
| - The extension now activates automatically when an `air.toml`, `DESCRIPTION`, or `.Rproj` file is detected at the workspace root. Previously, the extension only activated after an R file was opened (#285). | |||
There was a problem hiding this comment.
(Technically it also used to activate if any *.R file was detected at the workspace root, but I imagine that was rare for our current set of users and is not worth mentioning)
lionel-
reviewed
Mar 25, 2025
Comment on lines
-30
to
-31
| "workspaceContains:*.r", | ||
| "workspaceContains:*.R" |
There was a problem hiding this comment.
I think we should keep these for data analysis projects. This way the extension will be activated at the same time (project opening without any files open) for both packages and less structured projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #285
I didn't end up adding anything renv related, but I did add
*.Rprojwith the assumption that if you are opening a project that you previously used to open in RStudio, then you probably want Air to activate.