Skip to content

feat: add empty array integrations field to the manifest upon write-manifest #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

joshyam-k
Copy link
Contributor

@joshyam-k joshyam-k commented Aug 4, 2025

Intent

Add empty array "integrations" field to the manifest upon write-manifest. This is part of the work around auto-associating integrations with content upon deployment. See the main ticket for more information.

Fixes: #32761

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change

Approach

  • adds a TypedDict for the ManifestIntegrationRequests type
  • added empty integrations field into make_source_manifest
    • had to manually edit create_voila_manifest as it is the only one that doesn't call make_source_manifest internally.

Automated Tests

  • added new unit tests for each write_*_manifest_json function
  • updated existing unit tests that called make_source_manifest

make test passes

Checklist

  • I have updated CHANGELOG.md to cover notable changes.
  • I have updated all related GitHub issues to reflect their current state.

@joshyam-k joshyam-k marked this pull request as draft August 4, 2025 21:26
Copy link

github-actions bot commented Aug 4, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://posit-dev.github.io/rsconnect-python/pr-preview/pr-698/

Built to branch gh-pages at 2025-08-05 17:56 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

github-actions bot commented Aug 4, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
5161 4045 78% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
rsconnect/bundle.py 84% 🟢
TOTAL 84% 🟢

updated for commit: 405f4a1 by action🐍

@joshyam-k joshyam-k marked this pull request as ready for review August 5, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants