-
Notifications
You must be signed in to change notification settings - Fork 12
Resolved [Issue #25] Ease in creating commitfest #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sorry, can you rebase this on main and force push again? I had forced pushed to main to resolve an on the prod branch. You can do this by:
|
Actually something else seems to be off too, I don't see any commits that you authored in the list of commits for this PR. |
Could you check now? It is visible under the list of commits now. |
Yeah, I see it now. But it still needs a rebase. |
Updated commitfest\admin.py to ease the starting and ending action on a commitfest via a drop-down list.
It is rebased now, sorry for the inconvenience |
<<<<<<< HEAD | ||
- prod | ||
======= | ||
>>>>>>> 96758a1 (Implement github action to deploy to test environment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This contains a merge conflict.
class CommitfestAdmin(admin.ModelAdmin): | ||
@admin.action(description="Start selected Commitfest") | ||
def startCommitfest(self,request,queryset): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of integrating these in the admin panel I think it would feel more natural to put these buttons next to the admin buttons:
The "Start commitfest" button should also do something else important: Change the next "Future" commitfest to "Open", or if no "Future" commitfest exist, create a new "open" commitfest.
I will make the necessary changes and address the merge conflict |
@ChiragAJain do you still intend to update this PR? |
Sorry, I won't be. I have been caught up with few university commitments and can't find the time to review the code and make changes. |
Alright, no worries. I'll close this PR then, feel free to open a new one when you get time. |
As per the issue, actions under admin view have been added as a drop-down option in commitfest\admin.py to ease the starting and ending of a commitfest and automatically updating its end date.