-
Notifications
You must be signed in to change notification settings - Fork 59
Add meson.build file to support building from the contrib source tree. #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
meson.build
Outdated
'--temp-config', files('logical.conf') | ||
], | ||
}, | ||
'isolation': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
С изоляционными тестами могут быть проблемы. Насколько я понимаю, сейчас они вообще не запускаются.
По крайней мере, при выполнении
make check -C contrib/rum
их не видно.
Не факт, что они рабочие.
Мы их точно хотим включить в тестирование?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Оставил в надежде на починку изоляционных тестов. Думаю, убрать и добавить после починки будет логично.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Убрал блок для тестирования isolation совсем.
meson.build
Outdated
'rum_weight', | ||
'expr', | ||
], | ||
'regress_args': [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Если судить по Makefile, для регрессионных тестов
--temp-config $(top_srcdir)/contrib/rum/logical.conf
не используется.
Может, убрать?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Проверю и уберу, если действительно лишнее.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Убрал, действительно не нужно.
Заодно добавил забытый тест array.
5afb388
to
c2f0ad5
Compare
No description provided.