Skip to content

Add meson.build file to support building from the contrib source tree. #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

rzharkov
Copy link
Collaborator

No description provided.

meson.build Outdated
'--temp-config', files('logical.conf')
],
},
'isolation': {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

С изоляционными тестами могут быть проблемы. Насколько я понимаю, сейчас они вообще не запускаются.
По крайней мере, при выполнении
make check -C contrib/rum
их не видно.
Не факт, что они рабочие.
Мы их точно хотим включить в тестирование?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Оставил в надежде на починку изоляционных тестов. Думаю, убрать и добавить после починки будет логично.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Убрал блок для тестирования isolation совсем.

meson.build Outdated
'rum_weight',
'expr',
],
'regress_args': [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Если судить по Makefile, для регрессионных тестов
--temp-config $(top_srcdir)/contrib/rum/logical.conf
не используется.
Может, убрать?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Проверю и уберу, если действительно лишнее.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Убрал, действительно не нужно.
Заодно добавил забытый тест array.

@rzharkov rzharkov merged commit 4fe8191 into master Jan 24, 2025
1 of 2 checks passed
@rzharkov rzharkov deleted the meson_build_master branch January 24, 2025 11:16
@rzharkov rzharkov restored the meson_build_master branch January 24, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants