Simplify HTTPStatus by removing HTTPStatusCode

postolaki · Nov 9, 2018 · 26d5dd8 · 26d5dd8
1 parent 6390082
commit 26d5dd8
Show file tree

Hide file tree

Showing 3 changed files with 268 additions and 124 deletions.
diff --git a/Sources/Helpers/Deprecations.swift b/Sources/Helpers/Deprecations.swift
@@ -82,6 +82,11 @@ public extension HTTPStatus {
  static let noResponse = HTTPStatus(code: 444, phrase: "No Response")
 }
 
+// MARK: - HTTPStatusCode
+
+@available(*, deprecated, message: "use HTTPStatus, for example .ok or .notFound")
+public typealias HTTPStatusCode = HTTPStatus
+
 // MARK: - HTTPReponse
 
 public extension HTTPResponse {

diff --git a/Sources/Protocols/HTTP/Models/HTTPParser.swift b/Sources/Protocols/HTTP/Models/HTTPParser.swift
@@ -153,10 +153,8 @@ extension HTTPParser {
  // Not done parsing the status? Continue
  guard rawParser.isStatusComplete else { return continueParsing }
 
- // Check that the status is valid
+ // Validate and set the status
  guard let phrase = String(data: statusData, encoding: .utf8) else { return stopParsing }
-
- // Set the status
  response?.status = HTTPStatus(code: rawParser.httpStatusCode, phrase: phrase)
 
  return continueParsing