Fix an issue where too many error listeners would be attached to a ch…

…annel when publishing messages quickly.
postwait · Aug 30, 2013 · 8448e49 · 8448e49
1 parent 8f5f70d
commit 8448e49
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/lib/channel.js b/lib/channel.js
@@ -11,6 +11,8 @@ var methods = definitions.methods;
 // of Channel. This just provides a task queue.
 var Channel = module.exports = function Channel (connection, channel) {
   events.EventEmitter.call(this);
+  // Unlimited listeners. Helps when e.g. publishing high-volume messages, 10 is far too low.
+  this.setMaxListeners(0); 
 
   this.channel = channel;
   this.connection = connection;

diff --git a/lib/exchange.js b/lib/exchange.js
@@ -222,17 +222,16 @@ Exchange.prototype.publish = function (routingKey, data, options, callback) {
     self._sequence++;
 
     if(callback != null){
-      var errorCallback = function(){ 
+      var errorCallback = function(err){ 
         task.removeAllListeners();
-        callback(true); 
+        callback(true, err); 
       };
-      var exchange = this;
       task.once('ack', function(){
-        exchange.removeListener('error', errorCallback); 
+        self.removeListener('error', errorCallback); 
         task.removeAllListeners();
         callback(false);
       }); 
-      this.once('error', errorCallback);
+      self.once('error', errorCallback);
     }
   }