-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create bus.asm call to expose native BusInteraction to the backend #2510
Open
qwang98
wants to merge
16
commits into
main
Choose a base branch
from
native-bus-interaction-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a chat with @Schaeff, I opted for the method to simply expose native
|
Ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently just the bus.asm call is created. Next step will be editing
bus.rs
linker to do this call for backends that needs the native bus interaction.A key quesiton remains whether we need to import the backend crate or create another linker mode in the linker crate in order to distinguish which cases to pass down the native bus interaction vs which cases to call
bus_multi_linker
.A third solution is to make both
bus_multi_linker
andbus_native_linker
call inbus.rs
, and this will create bothBusInteraction
andPhantomBusInteraction
for all backends, and some backends can just ignore the nativeBusInteraction
, similar to what we've done for native lookup and permutation.