Fix some logging issues #242
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys,
This pull request addresses some logging issues I spotted long ago, but today I wanted to have certain PowerSync logs in my common app log, and this was time to fix them.
PowerSync
tag to the logs – as now the library has its own default logger instance, it deserves a tag;generateLogger()
global public method – it really seemed like a method meant to be used internally as it is quite specific, but even internally it is no longer needed.I didn't run any tests because I couldn't wait for the project to build. On my Intel Core Ultra 7 14x4.8 GHz with 32 GB of RAM the build didn't finish in 45 minutes, it's already late here and I should go to bed soon.