Skip to content

Fix some logging issues #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

Radiokot
Copy link
Contributor

@Radiokot Radiokot commented Aug 7, 2025

Hey guys,

This pull request addresses some logging issues I spotted long ago, but today I wanted to have certain PowerSync logs in my common app log, and this was time to fix them.

  1. Fixed modifying severity of the global Kermit logger – it is up to the app owner to decide on this parameter. The library no longer uses the global instance by default;
  2. Added PowerSync tag to the logs – as now the library has its own default logger instance, it deserves a tag;
  3. Removed generateLogger() global public method – it really seemed like a method meant to be used internally as it is quite specific, but even internally it is no longer needed.

I didn't run any tests because I couldn't wait for the project to build. On my Intel Core Ultra 7 14x4.8 GHz with 32 GB of RAM the build didn't finish in 45 minutes, it's already late here and I should go to bed soon.

@Radiokot
Copy link
Contributor Author

Radiokot commented Aug 7, 2025

Ok, seems that I shouldn't try to beat this lint without support from IDEA, but it doesn't work until the project is built, which it doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant