-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Remove filtering & rearranging controls from now playing overlay #32679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If filtering is to stay, I think it should be collections only, and it should match song select (ie selected collection should be a global game state). |
How far would you see that going? I guess this would also limit track playback game-wide to the selected collection? Can probably do, but may be best to do in a separate PR, this one is XL already and basically none of the old implementation is reusable for this so I'd essentially be reimplementing from scratch. Let me know if you want that here or no. |
Pretty much yeah. Separate / future is fine. |
RelativeSizeAxes = Axes.X; | ||
Height = 20; | ||
|
||
InternalChild = text = new OverflowScrollingContainer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sold on every long item always scrolling. Probably better only when hovered?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried, please see how you find b8360a1 (especially the behaviour when un-hovering mid-scroll).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd expect the scroll to reset to original position on unhovering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's how I had it initially and it was a much simpler implementation but I changed because it was a bit jarring. Guess I'll roll back...
Made some minor changes, please make sure you're okay with them! |
Changes look ok, thanks 👍 |
Screen.Recording.2025-04-04.at.13.17.26.mov
Reasons for removal:
RFC. Wanting to get this one off my forever task lists.
While the initial discussion was that filtering should stay, it's not easy (if at all possible) to make it work with
VirtualisedListContainer
. That consensus seemed weak anyway based on #28968 (comment). Filtering can maybe be salvaged if I try but I want to see the initial reaction to this as is.Overflowing items now scroll rather than wrap. This is forced because of
VirtualisedListContainer
's constraints (items need to have a fixed height).