Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken hidden cursor under release builds on macOS #20

Merged
merged 2 commits into from
Jun 6, 2018
Merged

Fix broken hidden cursor under release builds on macOS #20

merged 2 commits into from
Jun 6, 2018

Conversation

Tom94
Copy link

@Tom94 Tom94 commented Jun 4, 2018

What the title says. TL;DR: It is important to marshal bool as bool and not as int. Still need to investigate why exactly, but this got rid of all strange and spooky behaviour I was seeing. The other changes in this PR are not necessary for the code to work, but I'm leaving them in to make things more sane.

@Tom94
Copy link
Author

Tom94 commented Jun 4, 2018

I looked around a bit and it turns out the objective-C interface in question used the BOOL type, which is a typedef'd char from C. So, indeed, it was very incorrect to marshal 4-byte int into a function expecting 1-byte BOOL.

See https://developer.apple.com/documentation/appkit/nsbitmapimagerep/1395538-initwithbitmapdataplanes?language=objc

@peppy peppy merged commit 466a761 into ppy:netstandard Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants