Increase joystick button limit & prevent ghost press-release events from firing #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lifts the joystick button limit of 64. The fixed array performs marginally faster with a memory footprint increase of 112 bytes per device.
|
ok to raise the language version here or do you want me to rewrite the code? |
…ns & axes while being written
galister
changed the title
peppy
previously requested changes
Dec 14, 2019
smoogipoo
requested changes
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lifts the joystick button limit of 64 by using a fixed bool array instead of bit masked qword
The fixed array performs marginally faster with a memory footprint increase of 112 bytes per device.
Also fixes a race condition which can cause held buttons to trigger extra release and press events while being held.
Testing status
Comments