Review feedback

pquerna · Nov 16, 2016 · f693697 · f693697
1 parent 1016d9f
commit f693697
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/include/grpc++/support/channel_arguments.h b/include/grpc++/support/channel_arguments.h
@@ -107,7 +107,9 @@ class ChannelArguments {
   /// Set a textual argument \a value under \a key.
   void SetString(const grpc::string& key, const grpc::string& value);
 
-  grpc_channel_args c_args() {
+  /// Return (by value) a c grpc_channel_args structure which points to
+  /// arguments owned by this ChannelArguments instance
+  grpc_channel_args c_channel_args() {
     grpc_channel_args out;
     out.num_args = args_.size();
     out.args = args_.empty() ? NULL : &args_[0];

diff --git a/test/cpp/microbenchmarks/bm_fullstack.cc b/test/cpp/microbenchmarks/bm_fullstack.cc
@@ -164,7 +164,7 @@ class EndpointPairFixture {
       ChannelArguments args;
       args.SetString(GRPC_ARG_DEFAULT_AUTHORITY, "test.authority");
 
-      grpc_channel_args c_args = args.c_args();
+      grpc_channel_args c_args = args.c_channel_args();
       grpc_transport* transport =
           grpc_create_chttp2_transport(&exec_ctx, &c_args, endpoints.client, 1);
       GPR_ASSERT(transport);