Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle img tag without src attribute #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnjor
Copy link

@johnjor johnjor commented Oct 11, 2023

Fix for KeyError 'src' when encountering an img tag without a src attribute. Instead, it adds a paragraph with a placeholder, which is consistent with the other failure modes of this method. Added a test for this case.

…ribute. Instead, it adds a paragraph with a placeholder, which is consistent with the other failure modes of this method. Added a test for this case.
Copy link

@santosderek santosderek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm, we are affected by the same issue with having no src attribute and receiving a KeyError as a consequence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants