forked from apache/druid
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request apache#2505 from gianm/rt-exceptions
Harmonize realtime indexing loop across the task and standalone nodes.
- Loading branch information
Showing
3 changed files
with
82 additions
and
61 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78 changes: 78 additions & 0 deletions
78
server/src/main/java/io/druid/segment/realtime/plumber/Plumbers.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| /* | ||
| * Licensed to Metamarkets Group Inc. (Metamarkets) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. Metamarkets licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package io.druid.segment.realtime.plumber; | ||
|
|
||
| import com.google.common.base.Supplier; | ||
| import com.metamx.common.ISE; | ||
| import com.metamx.common.logger.Logger; | ||
| import com.metamx.common.parsers.ParseException; | ||
| import io.druid.data.input.Committer; | ||
| import io.druid.data.input.Firehose; | ||
| import io.druid.data.input.InputRow; | ||
| import io.druid.segment.incremental.IndexSizeExceededException; | ||
| import io.druid.segment.realtime.FireDepartmentMetrics; | ||
|
|
||
| public class Plumbers | ||
| { | ||
| private static final Logger log = new Logger(Plumbers.class); | ||
|
|
||
| private Plumbers() | ||
| { | ||
| // No instantiation | ||
| } | ||
|
|
||
| public static void addNextRow( | ||
| final Supplier<Committer> committerSupplier, | ||
| final Firehose firehose, | ||
| final Plumber plumber, | ||
| final FireDepartmentMetrics metrics | ||
| ) | ||
| { | ||
| try { | ||
| final InputRow inputRow = firehose.nextRow(); | ||
|
|
||
| if (inputRow == null) { | ||
| log.debug("Discarded null input row, considering unparseable."); | ||
| metrics.incrementUnparseable(); | ||
| return; | ||
| } | ||
|
|
||
| // Included in ParseException try/catch, as additional parsing can be done during indexing. | ||
| int numRows = plumber.add(inputRow, committerSupplier); | ||
|
|
||
| if (numRows == -1) { | ||
| metrics.incrementThrownAway(); | ||
| log.debug("Discarded row[%s], considering thrownAway.", inputRow); | ||
| return; | ||
| } | ||
|
|
||
| metrics.incrementProcessed(); | ||
| } | ||
| catch (ParseException e) { | ||
| log.debug(e, "Discarded row due to exception, considering unparseable."); | ||
| metrics.incrementUnparseable(); | ||
| } | ||
| catch (IndexSizeExceededException e) { | ||
| // Shouldn't happen if this is only being called by a single thread. | ||
| // plumber.add should be swapping out indexes before they fill up. | ||
| throw new ISE(e, "WTF?! Index size exceeded, this shouldn't happen. Bad Plumber!"); | ||
| } | ||
| } | ||
| } |