forked from mattermost/mattermost-webapp
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[MM-17546] Support plugin pagination in the Plugin Marketplace (matte…
…rmost#4567) Automatic Merge
- Loading branch information
Showing
13 changed files
with
710 additions
and
105 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
180 changes: 180 additions & 0 deletions
180
components/plugin_marketplace/marketplace_list/__snapshots__/marketplace_list.test.jsx.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,180 @@ | ||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
|
||
| exports[`components/marketplace/marketplace_list should render with multiple plugins 1`] = ` | ||
| <div | ||
| className="more-modal__list" | ||
| > | ||
| <Connect(MarketplaceItem) | ||
| description="This plugin sends quarterly user satisfaction surveys to gather feedback and help improve Mattermost" | ||
| downloadUrl="https://github.com/mattermost/mattermost-plugin-nps/releases/download/v1.0.3/com.mattermost.nps-1.0.3.tar.gz" | ||
| homepageUrl="https://github.com/mattermost/mattermost-plugin-nps" | ||
| id="com.mattermost.nps" | ||
| installedVersion="" | ||
| isPrepackaged={false} | ||
| key="com.mattermost.nps" | ||
| name="User Satisfaction Surveys" | ||
| version="1.0.3" | ||
| /> | ||
| <Connect(MarketplaceItem) | ||
| description="This plugin sends quarterly user satisfaction surveys to gather feedback and help improve Mattermost" | ||
| downloadUrl="https://github.com/mattermost/mattermost-plugin-nps/releases/download/v1.0.3/com.mattermost.nps-1.0.3.tar.gz" | ||
| homepageUrl="https://github.com/mattermost/mattermost-plugin-nps" | ||
| id="com.mattermost.nps" | ||
| installedVersion="" | ||
| isPrepackaged={false} | ||
| key="com.mattermost.nps" | ||
| name="User Satisfaction Surveys" | ||
| version="1.0.3" | ||
| /> | ||
| <Connect(MarketplaceItem) | ||
| description="This plugin sends quarterly user satisfaction surveys to gather feedback and help improve Mattermost" | ||
| downloadUrl="https://github.com/mattermost/mattermost-plugin-nps/releases/download/v1.0.3/com.mattermost.nps-1.0.3.tar.gz" | ||
| homepageUrl="https://github.com/mattermost/mattermost-plugin-nps" | ||
| id="com.mattermost.nps" | ||
| installedVersion="" | ||
| isPrepackaged={false} | ||
| key="com.mattermost.nps" | ||
| name="User Satisfaction Surveys" | ||
| version="1.0.3" | ||
| /> | ||
| <Connect(MarketplaceItem) | ||
| description="This plugin sends quarterly user satisfaction surveys to gather feedback and help improve Mattermost" | ||
| downloadUrl="https://github.com/mattermost/mattermost-plugin-nps/releases/download/v1.0.3/com.mattermost.nps-1.0.3.tar.gz" | ||
| homepageUrl="https://github.com/mattermost/mattermost-plugin-nps" | ||
| id="com.mattermost.nps" | ||
| installedVersion="" | ||
| isPrepackaged={false} | ||
| key="com.mattermost.nps" | ||
| name="User Satisfaction Surveys" | ||
| version="1.0.3" | ||
| /> | ||
| <Connect(MarketplaceItem) | ||
| description="This plugin sends quarterly user satisfaction surveys to gather feedback and help improve Mattermost" | ||
| downloadUrl="https://github.com/mattermost/mattermost-plugin-nps/releases/download/v1.0.3/com.mattermost.nps-1.0.3.tar.gz" | ||
| homepageUrl="https://github.com/mattermost/mattermost-plugin-nps" | ||
| id="com.mattermost.nps" | ||
| installedVersion="" | ||
| isPrepackaged={false} | ||
| key="com.mattermost.nps" | ||
| name="User Satisfaction Surveys" | ||
| version="1.0.3" | ||
| /> | ||
| <Connect(MarketplaceItem) | ||
| description="This plugin sends quarterly user satisfaction surveys to gather feedback and help improve Mattermost" | ||
| downloadUrl="https://github.com/mattermost/mattermost-plugin-nps/releases/download/v1.0.3/com.mattermost.nps-1.0.3.tar.gz" | ||
| homepageUrl="https://github.com/mattermost/mattermost-plugin-nps" | ||
| id="com.mattermost.nps" | ||
| installedVersion="" | ||
| isPrepackaged={false} | ||
| key="com.mattermost.nps" | ||
| name="User Satisfaction Surveys" | ||
| version="1.0.3" | ||
| /> | ||
| <Connect(MarketplaceItem) | ||
| description="This plugin sends quarterly user satisfaction surveys to gather feedback and help improve Mattermost" | ||
| downloadUrl="https://github.com/mattermost/mattermost-plugin-nps/releases/download/v1.0.3/com.mattermost.nps-1.0.3.tar.gz" | ||
| homepageUrl="https://github.com/mattermost/mattermost-plugin-nps" | ||
| id="com.mattermost.nps" | ||
| installedVersion="" | ||
| isPrepackaged={false} | ||
| key="com.mattermost.nps" | ||
| name="User Satisfaction Surveys" | ||
| version="1.0.3" | ||
| /> | ||
| <Connect(MarketplaceItem) | ||
| description="This plugin sends quarterly user satisfaction surveys to gather feedback and help improve Mattermost" | ||
| downloadUrl="https://github.com/mattermost/mattermost-plugin-nps/releases/download/v1.0.3/com.mattermost.nps-1.0.3.tar.gz" | ||
| homepageUrl="https://github.com/mattermost/mattermost-plugin-nps" | ||
| id="com.mattermost.nps" | ||
| installedVersion="" | ||
| isPrepackaged={false} | ||
| key="com.mattermost.nps" | ||
| name="User Satisfaction Surveys" | ||
| version="1.0.3" | ||
| /> | ||
| <Connect(MarketplaceItem) | ||
| description="This plugin sends quarterly user satisfaction surveys to gather feedback and help improve Mattermost" | ||
| downloadUrl="https://github.com/mattermost/mattermost-plugin-nps/releases/download/v1.0.3/com.mattermost.nps-1.0.3.tar.gz" | ||
| homepageUrl="https://github.com/mattermost/mattermost-plugin-nps" | ||
| id="com.mattermost.nps" | ||
| installedVersion="" | ||
| isPrepackaged={false} | ||
| key="com.mattermost.nps" | ||
| name="User Satisfaction Surveys" | ||
| version="1.0.3" | ||
| /> | ||
| <Connect(MarketplaceItem) | ||
| description="This plugin sends quarterly user satisfaction surveys to gather feedback and help improve Mattermost" | ||
| downloadUrl="https://github.com/mattermost/mattermost-plugin-nps/releases/download/v1.0.3/com.mattermost.nps-1.0.3.tar.gz" | ||
| homepageUrl="https://github.com/mattermost/mattermost-plugin-nps" | ||
| id="com.mattermost.nps" | ||
| installedVersion="" | ||
| isPrepackaged={false} | ||
| key="com.mattermost.nps" | ||
| name="User Satisfaction Surveys" | ||
| version="1.0.3" | ||
| /> | ||
| <Connect(MarketplaceItem) | ||
| description="This plugin sends quarterly user satisfaction surveys to gather feedback and help improve Mattermost" | ||
| downloadUrl="https://github.com/mattermost/mattermost-plugin-nps/releases/download/v1.0.3/com.mattermost.nps-1.0.3.tar.gz" | ||
| homepageUrl="https://github.com/mattermost/mattermost-plugin-nps" | ||
| id="com.mattermost.nps" | ||
| installedVersion="" | ||
| isPrepackaged={false} | ||
| key="com.mattermost.nps" | ||
| name="User Satisfaction Surveys" | ||
| version="1.0.3" | ||
| /> | ||
| <Connect(MarketplaceItem) | ||
| description="This plugin sends quarterly user satisfaction surveys to gather feedback and help improve Mattermost" | ||
| downloadUrl="https://github.com/mattermost/mattermost-plugin-nps/releases/download/v1.0.3/com.mattermost.nps-1.0.3.tar.gz" | ||
| homepageUrl="https://github.com/mattermost/mattermost-plugin-nps" | ||
| id="com.mattermost.nps" | ||
| installedVersion="" | ||
| isPrepackaged={false} | ||
| key="com.mattermost.nps" | ||
| name="User Satisfaction Surveys" | ||
| version="1.0.3" | ||
| /> | ||
| <Connect(MarketplaceItem) | ||
| description="This plugin sends quarterly user satisfaction surveys to gather feedback and help improve Mattermost" | ||
| downloadUrl="https://github.com/mattermost/mattermost-plugin-nps/releases/download/v1.0.3/com.mattermost.nps-1.0.3.tar.gz" | ||
| homepageUrl="https://github.com/mattermost/mattermost-plugin-nps" | ||
| id="com.mattermost.nps" | ||
| installedVersion="" | ||
| isPrepackaged={false} | ||
| key="com.mattermost.nps" | ||
| name="User Satisfaction Surveys" | ||
| version="1.0.3" | ||
| /> | ||
| <Connect(MarketplaceItem) | ||
| description="This plugin sends quarterly user satisfaction surveys to gather feedback and help improve Mattermost" | ||
| downloadUrl="https://github.com/mattermost/mattermost-plugin-nps/releases/download/v1.0.3/com.mattermost.nps-1.0.3.tar.gz" | ||
| homepageUrl="https://github.com/mattermost/mattermost-plugin-nps" | ||
| id="com.mattermost.nps" | ||
| installedVersion="" | ||
| isPrepackaged={false} | ||
| key="com.mattermost.nps" | ||
| name="User Satisfaction Surveys" | ||
| version="1.0.3" | ||
| /> | ||
| <Connect(MarketplaceItem) | ||
| description="This plugin sends quarterly user satisfaction surveys to gather feedback and help improve Mattermost" | ||
| downloadUrl="https://github.com/mattermost/mattermost-plugin-nps/releases/download/v1.0.3/com.mattermost.nps-1.0.3.tar.gz" | ||
| homepageUrl="https://github.com/mattermost/mattermost-plugin-nps" | ||
| id="com.mattermost.nps" | ||
| installedVersion="" | ||
| isPrepackaged={false} | ||
| key="com.mattermost.nps" | ||
| name="User Satisfaction Surveys" | ||
| version="1.0.3" | ||
| /> | ||
| <Connect(NavigationRow) | ||
| maximumPerPage={15} | ||
| onNextPageButtonClick={[Function]} | ||
| onPreviousPageButtonClick={[Function]} | ||
| page={0} | ||
| total={17} | ||
| /> | ||
| </div> | ||
| `; |
78 changes: 78 additions & 0 deletions
78
components/plugin_marketplace/marketplace_list/marketplace_list.jsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| // Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved. | ||
| // See LICENSE.txt for license information. | ||
|
|
||
| import React from 'react'; | ||
| import PropTypes from 'prop-types'; | ||
|
|
||
| import MarketplaceItem from '../marketplace_item'; | ||
|
|
||
| import NavigationRow from './navigation_row'; | ||
|
|
||
| const PLUGINS_PER_PAGE = 15; | ||
|
|
||
| export default class MarketplaceList extends React.PureComponent { | ||
| static propTypes = { | ||
| plugins: PropTypes.array.isRequired, | ||
| }; | ||
|
|
||
| static getDerivedStateFromProps(props, state) { | ||
| if (state.page > 0 && props.plugins.length < PLUGINS_PER_PAGE) { | ||
| return {page: 0}; | ||
| } | ||
|
|
||
| return null; | ||
| } | ||
|
|
||
| constructor(props) { | ||
| super(props); | ||
|
|
||
| this.state = { | ||
| page: 0, | ||
| }; | ||
| } | ||
|
|
||
| nextPage = () => { | ||
| this.setState((state) => ({ | ||
| page: state.page + 1 | ||
| })); | ||
| }; | ||
|
|
||
| previousPage = () => { | ||
| this.setState((state) => ({ | ||
| page: state.page - 1 | ||
| })); | ||
| }; | ||
|
|
||
| render() { | ||
| const pageStart = this.state.page * PLUGINS_PER_PAGE; | ||
| const pageEnd = pageStart + PLUGINS_PER_PAGE; | ||
| const pluginsToDisplay = this.props.plugins.slice(pageStart, pageEnd); | ||
|
|
||
| return ( | ||
| <div className='more-modal__list'> | ||
| {pluginsToDisplay.map((p) => ( | ||
| <MarketplaceItem | ||
| key={p.manifest.id} | ||
| id={p.manifest.id} | ||
| name={p.manifest.name} | ||
| description={p.manifest.description} | ||
| version={p.manifest.version} | ||
| isPrepackaged={false} | ||
| downloadUrl={p.download_url} | ||
| homepageUrl={p.homepage_url} | ||
| releaseNotesUrl={p.release_notes_url} | ||
| iconData={p.icon_data} | ||
| installedVersion={p.installed_version} | ||
| /> | ||
| ))} | ||
| <NavigationRow | ||
| page={this.state.page} | ||
| total={this.props.plugins.length} | ||
| maximumPerPage={PLUGINS_PER_PAGE} | ||
| onNextPageButtonClick={this.nextPage} | ||
| onPreviousPageButtonClick={this.previousPage} | ||
| /> | ||
| </div> | ||
| ); | ||
| } | ||
| } |
Oops, something went wrong.