Escape spaces in rpath with quotes #2433
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarod42
reviewed
Feb 21, 2025
src/tools/gcc.lua
Outdated
| @@ -426,6 +426,7 @@ | |||
|
|
|||
| for _, fullpath in ipairs(dirs) do | |||
| local rpath = path.getrelative(cfg.buildtarget.directory, fullpath) | |||
| rpath = p.quoted(rpath) -- quote in case of spaces in path | |||
There was a problem hiding this comment.
In "linker" mode, it is already surround (unconditionally) by '
nickclark2016
force-pushed
the
issues/2426
branch
from
0726f12 to
30bb617
Compare
samsinsane
requested changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Resolves #2426 - Escapes run paths with spaces using quotes
How does this PR change Premake's behavior?
No breaking changes
Anything else we should know?
N/A
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!