taskstats: cgroupstats_user_cmd() may leak on error

If prepare_reply() succeeds we have allocated memory for 'rep_skb'. If nla_reserve() then subsequently fails and returns NULL we fail to release the memory we allocated, thus causing a leak. Signed-off-by: Jesper Juhl <[email protected]> Cc: Balbir Singh <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
primiano · Oct 5, 2012 · 0324b5a · 0324b5a
1 parent 322c9ec
commit 0324b5a
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/kernel/taskstats.c b/kernel/taskstats.c
@@ -445,6 +445,7 @@ static int cgroupstats_user_cmd(struct sk_buff *skb, struct genl_info *info)
  na = nla_reserve(rep_skb, CGROUPSTATS_TYPE_CGROUP_STATS,
  sizeof(struct cgroupstats));
  if (na == NULL) {
+ nlmsg_free(rep_skb);
  rc = -EMSGSIZE;
  goto err;
  }