Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
net: irda: using kzalloc() instead of kmalloc() to avoid strncpy() is…
…sue. 'discovery->data.info' length is 22, NICKNAME_MAX_LEN is 21, so the strncpy() will always left the last byte of 'discovery->data.info' uninitialized. When 'text' length is longer than 21 (NICKNAME_MAX_LEN), if still left the last byte of 'discovery->data.info' uninitialized, the next strlen() will cause issue. Also 'discovery->data' is 'struct irda_device_info' which defined in "include/uapi/...", it may copy to user mode, so need whole initialized. All together, need use kzalloc() instead of kmalloc() to initialize all members firstly. Signed-off-by: Chen Gang <[email protected]> Signed-off-by: David S. Miller <[email protected]>
- Loading branch information