Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update water volume shader #384

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

hdoi5324
Copy link
Contributor

@hdoi5324 hdoi5324 commented Dec 4, 2024

This replaces the water volume PrincipledBSDFShader with a Volume Absorption and Volume Scattering shader to provide a better representation of light attenuation in water. The scattering shader can be updated with Blender 4.3 to use the phase 'Fournier-Forand' which models scattering in an underwater environment (commented out in water.py). The combination of Volume Absorption and Volume Scattering shaders is based on this post https://blender.stackexchange.com/questions/129220/how-to-create-an-underwater-scene-in-cycles

Example image from coral_reef.gin scene
Image_0_0_0048_0

@hdoi5324 hdoi5324 requested a review from araistrick as a code owner December 4, 2024 01:33
@araistrick
Copy link
Contributor

Thanks for the contribution!

I agree the water shader could use some work.

It seems this PR has gotten tangled with the other changes. would it be possible to cherrypick this out into an isolated branch?

The other thing that would be mildly useful is to make this an additional independent option for the water shader, rather than replacing the original. IE could you create a new file altogether called water_scatter.py or something similar? this would be maximally safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants