Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: add dark mode toggle functionality #2715

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

SnowyCrest
Copy link

Related Issue: #2714

Description

I have added functionality for users to choose between dark and light mode on the website. This is done through editing the tailwind CSS config and creating a handler for the two modes.
Since the styling of the text and layout was hardcoded to be black, I have also made sure the text is readable and clear on both themes.

Screenshots

Here's how the different modes look on the Homepage and the Projects, though this applies to all of the pages.


Homepage - Light Mode

Homepage - Dark Mode

Projects - Light Mode

Projects - Dark Mode

@github-actions github-actions bot added the wait for reviewers wait for the maintainer label Feb 14, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @SnowyCrest! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@SnowyCrest SnowyCrest changed the title style/ add dark mode toggle functionality style: add dark mode toggle functionality Feb 14, 2025
Copy link
Owner

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is something wrong with footer social links. could you please check it?

footer

@SnowyCrest
Copy link
Author

SnowyCrest commented Feb 15, 2025

I think there is something wrong with footer social links. could you please check it?

footer

Hey - sorry I didnt notice that. The issue was the <li> element had dots inbuilt between each of the social media icons. It should be fixed now.

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wait for reviewers wait for the maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants