-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aes fix #327
Aes fix #327
Conversation
added test for aes and zlib also add requested GetConfig that returns T in ConfigService
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I say "Separate NET and NETSTANDARD implementations" I mean
public class A
{
public T B()
{
return BInternal();
}
#if NET
public T BInternal()
{
}
// else will suffice
#elif NETSTANDARD
public T BInternal()
{
}
#endif
}
This is so that you don't have #if littered within the function itself and it's easier to see the separation and it makes it easier to add newer code in the future.
@SlejmUr changes look good! Please make sure you can reach the main menu in eft with your changes. |
cant even load the game with the mod, so i cant test |
Describe your changes
fix aes for proper enc/dec
added test for aes and zlib
also add requested GetConfig that returns T in ConfigService
Related issues (if any)
#141 #135
Checklist before requesting a review
dotnet test
)dotnet format
)