Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aes fix #327

Merged
merged 5 commits into from
Jan 13, 2025
Merged

Aes fix #327

merged 5 commits into from
Jan 13, 2025

Conversation

SlejmUr
Copy link
Contributor

@SlejmUr SlejmUr commented Jan 11, 2025

Describe your changes

fix aes for proper enc/dec
added test for aes and zlib
also add requested GetConfig that returns T in ConfigService

Related issues (if any)

#141 #135

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have thoroughly tested the code changes
  • I have verified that the client can launch with these changes
  • I have ran the unit tests (dotnet test)
  • I have the code formatter (dotnet format)
  • I have fixed all merge conflicts (if any)

added test for aes and zlib
also add requested GetConfig that returns T in ConfigService
@seionmoya seionmoya added bug Something isn't working launcher Related to Fuyu.Launcher backend Related to Fuyu.Backend labels Jan 11, 2025
@seionmoya seionmoya added this to the 0.1.0 milestone Jan 11, 2025
Copy link
Contributor

@nexus4880 nexus4880 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I say "Separate NET and NETSTANDARD implementations" I mean

public class A
{
    public T B()
    {
        return BInternal();
    }

#if NET

    public T BInternal()
    {
    }

// else will suffice
#elif NETSTANDARD

    public T BInternal()
    {
    }

#endif
}

This is so that you don't have #if littered within the function itself and it's easier to see the separation and it makes it easier to add newer code in the future.

Fuyu.Common/Config/ConfigService.cs Outdated Show resolved Hide resolved
Fuyu.Common/Hashing/AesHelper.cs Outdated Show resolved Hide resolved
Fuyu.Common/Hashing/AesHelper.cs Outdated Show resolved Hide resolved
Fuyu.Common/Hashing/Sha256.cs Show resolved Hide resolved
Fuyu.Common/Hashing/AesHelper.cs Outdated Show resolved Hide resolved
@seionmoya
Copy link
Collaborator

@SlejmUr changes look good! Please make sure you can reach the main menu in eft with your changes.

@SlejmUr
Copy link
Contributor Author

SlejmUr commented Jan 12, 2025

cant even load the game with the mod, so i cant test

@seionmoya seionmoya merged commit ee8ec49 into project-fika:dev Jan 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to Fuyu.Backend bug Something isn't working launcher Related to Fuyu.Launcher
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants