Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate the dedicated view of direct messages ("People") in the rooms list #323

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aaravlu
Copy link
Contributor

@aaravlu aaravlu commented Jan 14, 2025

issue #139

@aaravlu aaravlu changed the title Separate direct rooms Populate the dedicated view of direct messages ("People") in the rooms list Jan 14, 2025
@aaravlu
Copy link
Contributor Author

aaravlu commented Jan 14, 2025

Screencast.from.2025-01-14.16-12-01.webm

I will fix the issue in a later pr that user can select common room and direct room at the same time if you donnot mind. :)

@aaravlu aaravlu self-assigned this Jan 14, 2025
@aaravlu aaravlu added the waiting-on-review This issue is waiting to be reviewed label Jan 14, 2025
@aaravlu aaravlu requested a review from kevinaboos January 14, 2025 08:16
@kevinaboos
Copy link
Member

kevinaboos commented Jan 14, 2025

Hmm, I don't think we want to have separate scrollable lists for people and rooms -- those should be combined into a single scrollable list.

So the goal would be to have separate sections/headings within a single scroll list. That design will also work well with the room search/filter function, in which we may want to show only direct people rooms or only regular public rooms. It will also not waste vertical space, like what's shown in your screenshot with all the whitespace between the People and the Rooms sections.

@kevinaboos kevinaboos added waiting-on-author This issue is waiting on the original author for a response and removed waiting-on-review This issue is waiting to be reviewed labels Jan 14, 2025
@aaravlu
Copy link
Contributor Author

aaravlu commented Jan 15, 2025

Single list now:

Screencast.from.2025-01-15.15-31-38.webm

@aaravlu
Copy link
Contributor Author

aaravlu commented Jan 15, 2025

Hmm, I don't think we want to have separate scrollable lists for people and rooms -- those should be combined into a single scrollable list.

So the goal would be to have separate sections/headings within a single scroll list.

Considering that the implementation methods are quite different, I force pushed.

@aaravlu aaravlu added waiting-on-review This issue is waiting to be reviewed waiting-on-author This issue is waiting on the original author for a response and removed waiting-on-author This issue is waiting on the original author for a response waiting-on-review This issue is waiting to be reviewed labels Jan 15, 2025
@aaravlu
Copy link
Contributor Author

aaravlu commented Jan 15, 2025

Bug:

Screencast.from.2025-01-15.18-01-48.webm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on-author This issue is waiting on the original author for a response
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants