-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: namespace metadata sync on creation #1378 #1379
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for capsule-documentation canceled.
|
Hey until the new implementation is done i am happy to consider this one, could you adsd one e2e test? |
2100c2d
to
f900474
Compare
Signed-off-by: Siarhei Rasiukevich <[email protected]>
Signed-off-by: Siarhei Rasiukevich <[email protected]>
Hello @oliverbaehler At first look, I thought this change would be a quick 5-minute adventure. But soon I have realized that all mutation changes need to be handled in a single place. This PR will guarantee consistent namespace metadata on creation/reconcile. I have also added e2e for both webhook and controller namespace reconcile. Additionally, I encountered issues with the Harpoon image: Please take a look when you'll have time. |
/retest |
Have no failed test in trace-e2e on my ubuntu workstation. |
Closes #1378
Sync metadata on namespace creation