Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add speedtest-exporter #1894

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add speedtest-exporter #1894

wants to merge 1 commit into from

Conversation

MiguelNdeCarvalho
Copy link

closes #1893

@MiguelNdeCarvalho
Add speedtest-exporter
9e42828 
Signed-off-by: MiguelNdeCarvalho <[email protected]>
@beorn7 beorn7 added the exporters and integrations Requests for new entries in the list of exporters and integrations label Mar 5, 2021
hdost
hdost approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@hdost hdost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @juliusv

@juliusv
Copy link
Member

juliusv commented Jul 11, 2022

Thanks! @beorn7 wanted to bring up again in the DevSummit recently whether we should change our policy of listing only one integration for each use case: https://docs.google.com/document/d/11LC3wJcVk00l8w5P3oLQ-m3Y37iom6INAMEu2ZAGIIE/edit#bookmark=id.qq4qym4wmqe

But it seems we haven't managed to get around to discussing that yet. From my side I would be happy to list both for now, what do you think @beorn7?

@beorn7
Copy link
Member

beorn7 commented Jul 11, 2022

I think we should allow multiple entries for the same problem with some explanation attached about the different trade-offs.
However, that's clearly at odds with our explicitly stated practice in the past. That's why I think we should first discuss this topic at a dev summit before changing our practice.

@RichiH
Copy link
Member

RichiH commented Jul 13, 2022

Given current votes, it seems likely we'll get to discuss it at the next dev summit on 2022-07-28.

@juliusv
Copy link
Member

juliusv commented Jul 13, 2022

Sounds good to me! @MiguelNdeCarvalho sorry for the delay, but then for good measure I also think it's best to discuss it formally first, as it has been a contentious point for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdost hdost hdost approved these changes

Assignees
No one assigned
Labels
exporters and integrations Requests for new entries in the list of exporters and integrations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add speedtest-exporter
5 participants
@MiguelNdeCarvalho @juliusv @beorn7 @RichiH @hdost