Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for only posting warnings to added/modified lines #89

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
87448b2
Add configuration for only posting warnings to added/modified lines
Phillita Mar 28, 2024
fb99588
Allow warnings to be caught within a range
Phillita Apr 1, 2024
7e82368
Update README.md
Phillita Apr 1, 2024
4eff31f
End code example
Phillita Apr 1, 2024
550a64f
Add messaging for indirect offenses
Phillita Apr 18, 2024
5a4ea52
Exctract suggestion into new class to help with ruby critic.
Phillita Apr 18, 2024
c261633
Remove some linter warnings. Add support folder to rspec
Phillita Jun 18, 2024
3bc66f4
Add a documentation url to messages
Phillita Jun 18, 2024
c852517
fix deprecated method warnings with Rubocop 1.65+
ramil350 Aug 20, 2024
5d9f1c2
update README and gemspec
ashkulz Jan 11, 2025
9b36cd3
add Ruby 3.3 and 3.4 to the CI matrix
ashkulz Jan 11, 2025
539096f
setup Dependabot and Trusted Publishing workflow
ashkulz Jan 11, 2025
61eb5ad
bump version to 0.11.6
ashkulz Jan 11, 2025
3feb4c1
push_gem: fix repository name
ashkulz Jan 11, 2025
1fdafa8
Merge branch 'master' into comments-for-changed-lines-only
Phillita Jan 11, 2025
84a6a83
Remove byebug
Phillita Jan 13, 2025
8d65883
Remove rubocop from the gemspec.
Phillita Jan 13, 2025
9660c94
Reverted rubocop in the gemfile and moved it back to the gemspec
Phillita Jan 13, 2025
91556f7
Add base64 to the gemfile
Phillita Jan 13, 2025
449593d
Revert Gemfile/Gemspec gem changes
Phillita Jan 15, 2025
c08baaf
Move the string contants inline and remove unused.
Phillita Jan 15, 2025
db6e18a
Use the built in documentation_url from rubocop
Phillita Jan 16, 2025
a57b702
Merge offense_suggestion into offense_line
Phillita Jan 16, 2025
2b59c14
Remove the require offense_suggestion
Phillita Jan 16, 2025
46b828f
Update checks to remove anything below rubocop 0.90.0
Phillita Jan 20, 2025
d5948ec
Remove gemspec rubocop changes
Phillita Jan 20, 2025
82ccbfb
Remove readme section for old rubocop versions
Phillita Jan 20, 2025
d2d0bf6
Add ruby 2.3 back to the CI checks for the min rubocop version
Phillita Jan 20, 2025
17ec00d
Remove unneeded comments from the offense line
Phillita Jan 20, 2025
173d4e1
Bump up the required ruby version to 2.4
Phillita Jan 21, 2025
9ed868c
CI checks updated for ruby 2.3 removal
Phillita Jan 21, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move the string contants inline and remove unused.
  • Loading branch information
Phillita committed Jan 15, 2025
commit c08baafc0dcddaf5346465f5553f3efbc9884d86
8 changes: 2 additions & 6 deletions lib/pronto/rubocop/offense_line.rb
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,11 @@ def indirect_offense?
end

def indirect_message
INDIRECT_MESSAGE % offense.location.first_line if indirect_offense?
"Offense generated for line #{offense.location.first_line}:\n\n" if indirect_offense?
end

def indirect_suggestion
INDIRECT_SUGGESTION % offense.location.first_line if indirect_offense?
"Suggestion for line #{offense.location.first_line}:\n\n" if indirect_offense?
end

def suggestable?
Expand Down Expand Up @@ -88,10 +88,6 @@ def config_severities
error: :error,
fatal: :fatal
}.freeze
SUGGESTION = 'suggestion'
RUBY = 'ruby'
INDIRECT_MESSAGE = "Offense generated for line %d:\n\n"
INDIRECT_SUGGESTION = "Suggestion for line %d:\n\n"

private_constant :DEFAULT_SEVERITIES
end
Expand Down
Loading