Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What: Allow proto definition providers to specify the root of the pro… #30

Open
wants to merge 5 commits into
base: development
Choose a base branch
from
Open

What: Allow proto definition providers to specify the root of the pro… #30

wants to merge 5 commits into from

Conversation

noel-yap
Copy link
Contributor

…to directory hierarchy.

Why: To allow greater flexibility in source code organization.

This was referenced Sep 16, 2020
Open
Open
jefferyshivers
jefferyshivers reviewed Oct 2, 2020
View reviewed changes
Copy link
Contributor

@jefferyshivers jefferyshivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this - apologies for the delay, but this is on my list to review and test over the weekend

@noel-yap
Copy link
Contributor Author

noel-yap commented Oct 2, 2020

Thanks for letting me know. I was starting to get worried.

@noel-yap
What: Allow proto definition providers to specify the root of the pro…
5f4d2e8 
…to directory hierarchy.

Why: To allow greater flexibility in source code organization.
@noel-yap noel-yap force-pushed the feature/allow-root-specification branch from b25648c to 5f4d2e8 Compare October 7, 2020 16:42
@noel-yap noel-yap force-pushed the feature/allow-root-specification branch 2 times, most recently from 90a68ba to a90bbfd Compare October 20, 2020 14:11
@noel-yap noel-yap force-pushed the feature/allow-root-specification branch 2 times, most recently from 4ee189b to c2ebc98 Compare December 24, 2020 05:48
@noel-yap
Copy link
Contributor Author

noel-yap commented Dec 24, 2020 •
edited
Loading

@jefferyshivers , I'm trying to merge but the CI is failing with:

Execution failed for task ':protop-core:protopSync'.
> A problem occurred starting process 'command 'protop''

and I'm not able to reproduce the problem locally. Any ideas what may be causing this?

I'm wondering if it's because of:

plugins {
    id "com.google.protobuf" version "0.8.12"
    id "io.protop" version "0.2.0"
}

in protop-core/build.gradle. Isn't that a circular dependency in that the Gradle plugin uses protop itself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefferyshivers jefferyshivers jefferyshivers left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noel-yap @jefferyshivers