fix(kubernetes): Change UID validation #6869
Open
+35
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfagoagas
commented
Feb 7, 2025
api/src/backend/api/models.py
Outdated
| value, | ||
| ): | ||
| raise ModelValidationError( | ||
| detail="The value must either be a valid Kubernetes UID (up to 63 characters, " | ||
| "starting and ending with a lowercase letter or number, containing only " | ||
| "lowercase alphanumeric characters and hyphens) or a valid EKS ARN.", | ||
| "lowercase alphanumeric characters and hyphens) or a valid AWS EKS ARN, GCP GKE ID or Azure AKS ID.", |
There was a problem hiding this comment.
@MrCloudSec could you please review the wording here? Thanks!
jfagoagas
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6869 +/- ##
==========================================
+ Coverage 93.40% 93.45% +0.05%
==========================================
Files 70 71 +1
Lines 6412 6446 +34
==========================================
+ Hits 5989 6024 +35
+ Misses 423 422 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
MrCloudSec
reviewed
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change Kubernetes provider validation:
^[a-z0-9][A-Za-z0-9_.:\/-]{1,250}$Now the following K8s cluster names from AWS EKS, AKS and GKE can be added:
arn:aws:eks:us-east-1:111122223333:cluster/test-cluster-name-longer-than-63-charactersgke_aaaa-dev_europe-test1_dev-aaaa-cluster-name-longer-than-63-charactersChecklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.