-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: migrate Azure resource models to avoid using SDK defaults #6880
Open
puchy22
wants to merge
25
commits into
master
Choose a base branch
from
PRWLR-6087-migrate-azure-resource-models-to-stop-using-the-default-given-by-the-sdk
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: migrate Azure resource models to avoid using SDK defaults #6880
puchy22
wants to merge
25
commits into
master
from
PRWLR-6087-migrate-azure-resource-models-to-stop-using-the-default-given-by-the-sdk
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nerRegistry attribute
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6880 +/- ##
==========================================
- Coverage 88.75% 88.72% -0.04%
==========================================
Files 1200 1200
Lines 34611 34822 +211
==========================================
+ Hits 30720 30896 +176
- Misses 3891 3926 +35
Flags with carried forward coverage won't be shown. Click here to find out more.
|
because some users could not have it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Use default models from Azure SDK was causing problem.
Fix #6698
Description
Search all models from Azure SDK, review what attributes are needed for checks and create a new model with that attributes and change the constructor when they are created in the service and change tests if needed.
Checklist
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.