Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate Azure resource models to avoid using SDK defaults #6880

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

puchy22
Copy link
Member

@puchy22 puchy22 commented Feb 10, 2025

Context

Use default models from Azure SDK was causing problem.

Fix #6698

Description

Search all models from Azure SDK, review what attributes are needed for checks and create a new model with that attributes and change the constructor when they are created in the service and change tests if needed.

Checklist

API

  • Verify if API specs need to be regenerated.
  • Check if version updates are required (e.g., specs, Poetry, etc.).
  • Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@puchy22 puchy22 requested review from a team as code owners February 10, 2025 17:12
@github-actions github-actions bot added the provider/azure Issues/PRs related with the Azure provider label Feb 10, 2025
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 92.62673% with 16 lines in your changes missing coverage. Please review.

Project coverage is 88.72%. Comparing base (fb5ea3c) to head (feb78ac).
Report is 24 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6880      +/-   ##
==========================================
- Coverage   88.75%   88.72%   -0.04%     
==========================================
  Files        1200     1200              
  Lines       34611    34822     +211     
==========================================
+ Hits        30720    30896     +176     
- Misses       3891     3926      +35     
Flag Coverage Δ
prowler 88.72% <92.62%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 88.72% <92.62%> (-0.04%) ⬇️
api ∅ <ø> (∅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/azure Issues/PRs related with the Azure provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error at ocsf modeling during Azure execution
1 participant