Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactor and bug fixes related to bgm. #1444

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Wolf3s
Copy link
Contributor

@Wolf3s Wolf3s commented Jan 1, 2025

Pull Request checklist

Note: these are not necessarily requirements

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK or other dependencies
  • Others (please specify below)

Pull Request description

This cleanups and refactors opl as whole.
Changes being made so far:

  • Removed redudant includes
  • Refactored menu.c and audio.c
  • Moved all embedded files to the newly imports.h(extern-irx.h)
  • Fix game launching when bgm is activated.

TBD:

  • Split opl.c
  • Cleanup ee_core
  • Refactor all the modules

Size:

Master branch build:
1.337.044 bytes
Cleanup branch build:
1.336.436 bytes

NOTE: There´s a branch that i will push some experiments and with time. I perhaps merge.
Happy new year for all!!!

@Wolf3s Wolf3s force-pushed the Cleanups branch 7 times, most recently from 4b95842 to c563aa2 Compare January 1, 2025 20:44
Remove hack code inside of sound.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant