Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a URL config #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

AstraLuma
Copy link

Add a config option to specify TLS, token, host, and prefix as a single URL.

@AstraLuma
Copy link
Author

AstraLuma commented Sep 21, 2024

(Context: fly.io does this, and a PR seemed easier than some kind of entrypoint parsing script)

@AstraLuma AstraLuma marked this pull request as ready for review September 21, 2024 15:48
@AstraLuma
Copy link
Author

xcaddy adapt seems to produce the expected output, so I'm going to call this good. I don't see any tests to add to.

@AstraLuma AstraLuma marked this pull request as draft September 21, 2024 17:03
@AstraLuma AstraLuma marked this pull request as ready for review September 21, 2024 17:42
@AstraLuma
Copy link
Author

Caddyfiles now have native support for environment variables, so you could drop the envvar checking code in favor of explicit config?

@pteich
Copy link
Owner

pteich commented Oct 17, 2024

I'll have a look. I think I won't drop env vars as this would break at least all of my deployments ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants