Add interop for Atomics #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulyaevskiy
reviewed
Oct 28, 2020
node_interop/lib/atomics.dart
Outdated
| // Copyright (c) 2020, Anatoly Pulyaevskiy. All rights reserved. Use of this source code | ||
| // is governed by a BSD-style license that can be found in the LICENSE file. | ||
|
|
||
| /// Bindings for the Atomics JavaScript obect. Since this object only has static |
node_interop/lib/atomics.dart
Outdated
|
|
||
| /// Bindings for the Atomics JavaScript obect. Since this object only has static | ||
| /// methods, it's exposed as a module so that it can be used in the standard | ||
| /// Dart style. |
There was a problem hiding this comment.
One thing I prefer to preserve, if possible, is to keep bindings closer to the actual JS API. What do you think of adding a container Atomics abstract class and making the below methods static inside it? I think JS interop supports external static methods, but I'm not 100% sure.
node_interop/lib/atomics.dart
Outdated
| /// methods, it's exposed as a module so that it can be used in the standard | ||
| /// Dart style. | ||
| @JS() | ||
| library node_interop.atomics; |
There was a problem hiding this comment.
Also, it looks like Atomics is a global JS object, so we need to add an export of atomics in lib/node.dart which is where all the global stuff is exported.
|
Moved it into |
pulyaevskiy
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.