Skip to content

Commit

Permalink
lib: utils: Add SiFive test device
Browse files Browse the repository at this point in the history
This patch factor-out SiFive test device related stuff into
it's own source file from qemu/virt platform. In future, we
can find SiFive test device address from device tree as well.

Signed-off-by: Anup Patel <[email protected]>
Reviewed-by: Atish Patra <[email protected]>
  • Loading branch information
avpatel committed Apr 27, 2020
1 parent a9eac67 commit 6585fab
Show file tree
Hide file tree
Showing 4 changed files with 75 additions and 13 deletions.
19 changes: 19 additions & 0 deletions include/sbi_utils/sys/sifive_test.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
/*
* SPDX-License-Identifier: BSD-3-Clause
*
* Copyright (c) 2020 Western Digital Corporation or its affiliates.
*
* Authors:
* Anup Patel <[email protected]>
*/

#ifndef __SYS_SIFIVE_TEST_H__
#define __SYS_SIFIVE_TEST_H__

#include <sbi/sbi_types.h>

int sifive_test_system_reset(u32 type);

int sifive_test_init(unsigned long base);

#endif
1 change: 1 addition & 0 deletions lib/utils/sys/objects.mk
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@

libsbiutils-objs-y += sys/clint.o
libsbiutils-objs-y += sys/htif.o
libsbiutils-objs-y += sys/sifive_test.o
44 changes: 44 additions & 0 deletions lib/utils/sys/sifive_test.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
/*
* SPDX-License-Identifier: BSD-3-Clause
*
* Copyright (c) 2020 Western Digital Corporation or its affiliates.
*
* Authors:
* Anup Patel <[email protected]>
*/

#include <sbi/riscv_io.h>
#include <sbi/sbi_platform.h>
#include <sbi_utils/sys/sifive_test.h>

#define FINISHER_FAIL 0x3333
#define FINISHER_PASS 0x5555
#define FINISHER_RESET 0x7777

static void *sifive_test_base;

int sifive_test_system_reset(u32 type)
{
/*
* Tell the "finisher" that the simulation
* was successful so that QEMU exits
*/
switch (type) {
case SBI_PLATFORM_RESET_SHUTDOWN:
writew(FINISHER_PASS, sifive_test_base);
break;
case SBI_PLATFORM_RESET_COLD:
case SBI_PLATFORM_RESET_WARM:
writew(FINISHER_RESET, sifive_test_base);
break;
}

return 0;
}

int sifive_test_init(unsigned long base)
{
sifive_test_base = (void *)base;

return 0;
}
24 changes: 11 additions & 13 deletions platform/qemu/virt/platform.c
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,13 @@
#include <sbi_utils/irqchip/plic.h>
#include <sbi_utils/serial/uart8250.h>
#include <sbi_utils/sys/clint.h>
#include <sbi_utils/sys/sifive_test.h>

/* clang-format off */

#define VIRT_HART_COUNT 8

#define VIRT_TEST_ADDR 0x100000
#define VIRT_TEST_FINISHER_FAIL 0x3333
#define VIRT_TEST_FINISHER_PASS 0x5555

#define VIRT_CLINT_ADDR 0x2000000

Expand All @@ -39,6 +38,14 @@

/* clang-format on */

static int virt_early_init(bool cold_boot)
{
if (!cold_boot)
return 0;

return sifive_test_init(VIRT_TEST_ADDR);
}

static int virt_final_init(bool cold_boot)
{
void *fdt;
Expand Down Expand Up @@ -100,17 +107,8 @@ static int virt_timer_init(bool cold_boot)
return clint_warm_timer_init();
}

static int virt_system_reset(u32 type)
{
/* Tell the "finisher" that the simulation
* was successful so that QEMU exits
*/
writew(VIRT_TEST_FINISHER_PASS, (void *)VIRT_TEST_ADDR);

return 0;
}

const struct sbi_platform_operations platform_ops = {
.early_init = virt_early_init,
.final_init = virt_final_init,
.console_putc = uart8250_putc,
.console_getc = uart8250_getc,
Expand All @@ -123,7 +121,7 @@ const struct sbi_platform_operations platform_ops = {
.timer_event_stop = clint_timer_event_stop,
.timer_event_start = clint_timer_event_start,
.timer_init = virt_timer_init,
.system_reset = virt_system_reset,
.system_reset = sifive_test_system_reset,
};

const struct sbi_platform platform = {
Expand Down

0 comments on commit 6585fab

Please sign in to comment.