To array and to sparse functions are ready for linearoperator #368
Conversation
… _tosparse_array, that contains the functionality to get both the sparse matrix and the full matrix
…ide the main for loop that kept allocating memory unecessarily
|
@mateomarin97 We see that you have made changes to the code after Elena's questions, but it is not clear what exactly they are for. Could you please answer explicitly? |
Hello. The changes were just aesthetic. I made the code more readable by implementing the suggestions Elena mentioned. The only thing stopping this function from being ready is that for the sparse matrix case, I could not write a Pyccel kernel to replace the for loop that appends the new matrices entries since Pyccel did not support Python lists. As the code stands it works but it is too slow due to this problem. |
Now that I think about it I am fairly certain I have a newer version of this branch that I did not push. I will push it later. |
psydac/linalg/basic.py
Outdated
| 'The codomain of the LinearOperator must be a BlockVectorSpace or a StencilVectorSpace.') | ||
|
|
||
| if BoS == "b": | ||
| comm = self.domain.spaces[0].cart.comm |
There was a problem hiding this comment.
I think it would be better to write this line right after 255 (within the if of 254). Same comment for the rest of if's.
psydac/linalg/basic.py
Outdated
| itterables2 = [] | ||
| for ii in range(ndim2): | ||
| itterables2.append([starts2[ii], ends2[ii]+1]) | ||
| #itterables2.append(range(starts2[ii], ends2[ii]+1)) |
There was a problem hiding this comment.
Please clean the comments in the code
There was a problem hiding this comment.
Ok. I will clean up the code and take this into consideration
Erased unnecessary file.
The default toarray and tosparse functions have been added to linearoperator.
Also, parallel tests for these functions have been written.