Tags Builder #534
Open
Tags Builder #534
+595
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement TagBuilder abstract class with a method to format content - Add XMLTagBuilder class that inherits from TagBuilder - Define format_tag function to build tags using specified dialect - Include initial test for content formatting with DummyTagBuilder
- Removed Content type alias and replaced with Any - Updated format_tag function to accept Any type for content - Simplified _normalize_type function to handle Any type - Adjusted TagBuilder and XMLTagBuilder to work with Any type - Added complex content formatting tests in test_prompt.py
|
@samuelcolvin I should have checked if a similar PR already exists, but I've modified my PR just in case. If you'd rather use #515 , go ahead and close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created the logic for building XML-like tags. The original issue mentions only
examples, but my version allows for the creation of any tag.Closes #93