Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New structure with new libraries for InitialPop, Production and Dispersal #364

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

mcwimm
Copy link
Collaborator

@mcwimm mcwimm commented Nov 7, 2024

Previously we had 1 library managing the initial population and recruitment, including the number of recruits, their size and distribution. This has now been split into three sublibraries which define the initial population, the production of seeds or seedlings and their dispersal. This naturally leads to a new structure for the control file.

The current implementation should allow for backward compatibility.

The implementation of the following modules is still missing:

  • size dependent seed production
  • weighted dispersal
  • parent-dependet dispersal

Please check out the dcos, too.
(You can build them locally with: pdoc --docformat google --math --mermaid -o ./docs ../pyMANGA/)

Copy link
Collaborator

@ChrisWudel ChrisWudel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Marie,

I’ve reviewed the changes and believe they are correct. I couldn’t find any errors. The only thing I noticed is that in the XML files, the start and end times are given differently. While this doesn’t lead to errors, it is a bit inconsistent.

I also reviewed the documentation, and nothing else stood out to me. Everything was clear and understandable.

Afterward, I tested all the modified XML files, including with different parameters. All of them worked, except for BenchmarkList.xml. This one didn’t work, though I’m not sure if it’s supposed to.

Best regards,
Chris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants