-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New structure with new libraries for InitialPop, Production and Dispersal #364
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Marie,
I’ve reviewed the changes and believe they are correct. I couldn’t find any errors. The only thing I noticed is that in the XML files, the start and end times are given differently. While this doesn’t lead to errors, it is a bit inconsistent.
I also reviewed the documentation, and nothing else stood out to me. Everything was clear and understandable.
Afterward, I tested all the modified XML files, including with different parameters. All of them worked, except for BenchmarkList.xml. This one didn’t work, though I’m not sure if it’s supposed to.
Best regards,
Chris
0843f7e
to
4a3f517
Compare
Previously we had 1 library managing the initial population and recruitment, including the number of recruits, their size and distribution. This has now been split into three sublibraries which define the initial population, the production of seeds or seedlings and their dispersal. This naturally leads to a new structure for the control file.
The current implementation should allow for backward compatibility.
The implementation of the following modules is still missing:
Please check out the dcos, too.
(You can build them locally with:
pdoc --docformat google --math --mermaid -o ./docs ../pyMANGA/
)