Skip to content

Commit

Permalink
Add review suggestions around code comments
Browse files Browse the repository at this point in the history
Co-authored-by: Jason R. Coombs <[email protected]>
Co-authored-by: Avasam <[email protected]>
  • Loading branch information
3 people authored Dec 26, 2024
1 parent 2930193 commit f5b7336
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion distutils/extension.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ def __init__(
if not isinstance(name, str):
raise AssertionError("'name' must be a string") # noqa: TRY004

# we handle the string case first; though strings are iterable, we disallow them
# handle the string case first; since strings are iterable, disallow them
if isinstance(sources, str):
raise AssertionError( # noqa: TRY004
"'sources' must be an iterable of strings or PathLike objects, not a string"
Expand Down
2 changes: 1 addition & 1 deletion distutils/tests/test_extension.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def test_extension_init(self):
assert ext.name == 'name'

# the second argument, which is the list of files, must
# be a list of strings or PathLike objects, and not a string
# be an iterable of strings or PathLike objects, and not a string
with pytest.raises(AssertionError):
Extension('name', 'file')
with pytest.raises(AssertionError):
Expand Down

0 comments on commit f5b7336

Please sign in to comment.