Always remove authority section when cleaning local URL path #13510
+9
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barneygale
force-pushed
the
always-remove-netloc-when-cleaning
branch
from
f51b3ca to
cdad848
Compare
barneygale
force-pushed
the
always-remove-netloc-when-cleaning
branch
from
cdad848 to
beb4a8d
Compare
|
@ichard26 another one for you! :D This one fixes all the test cases that were expecting |
barneygale
commented
Jul 27, 2025
| # Trailing slashes are now preserved on Windows, matching POSIX behaviour. | ||
| # BPO: https://github.com/python/cpython/issues/126212 | ||
| does_pathname2url_preserve_trailing_slash = pathname2url("C:/foo/").endswith("/") | ||
| does_pathname2url_preserve_trailing_slash = pathname2url("C:\\foo\\").endswith("/") |
There was a problem hiding this comment.
This detection didn't work correctly, but I suspect it didn't matter because the has_new_urlun_behavior value coincided.
There was a problem hiding this comment.
(took me flippin ages to figure this out!)
ichard26
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pathname2url()generates a URL with an authority section on Windows (all versions) and non-Windows (3.12+ for paths beginning//, 3.14+ for paths beginning/). We need to strip this prefix in order to return a URL path rather than a complete URL.