-
Notifications
You must be signed in to change notification settings - Fork 34
Prepare for Python 3.14 support #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: AA-Turner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the approach is to let the bot generate the list - is that right @woodruffw ?
I had the bot create AA-Turner#1 (merged into this branch) via https://github.com/AA-Turner/stdlib-list/actions/runs/16976344998, but happy to revert? |
Yeah, having the bot do the generation would be ideal. If you could revert just that file that would be perfect, thanks @AA-Turner! |
Done @woodruffw (I'm using A |
No issue at all! |
Ah, I under-thought this a bit -- this needs to first have the list primed, and then we'll do a follow-up PR to add |
@woodruffw can you take over the branch? I'm confused by what changes are needed and in what order, it seems rather complex. |
Yep, doing 🙂 -- I only had to remove one line, which will need a follow-up PR once the CI generates the 3.14 list. |
Thanks @AA-Turner! |
Wonderful, thank you @woodruffw. I had hoped to side-step the complexity by including the generated file in the PR, but clearly no such luck to be had! A |
Yeah, turns out that's 100% my bad...I thought the list generation would do this gracefully in CI, but based on how #168 failed initially I was wrong about that 😅 Sorry for the extra steps! |
Hopefully updated all the right places.
A