Skip to content

Conversation

AA-Turner
Copy link
Contributor

Hopefully updated all the right places.

A

Copy link
Member

@miketheman miketheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the approach is to let the bot generate the list - is that right @woodruffw ?

@AA-Turner
Copy link
Contributor Author

I had the bot create AA-Turner#1 (merged into this branch) via https://github.com/AA-Turner/stdlib-list/actions/runs/16976344998, but happy to revert?

@woodruffw
Copy link
Member

Yeah, having the bot do the generation would be ideal. If you could revert just that file that would be perfect, thanks @AA-Turner!

@AA-Turner
Copy link
Contributor Author

Done @woodruffw

(I'm using github.dev for this PR & I can't figure out how to have it show me the git log, so I've just deleted the file rather than a proper revert -- sorry!)

A

@AA-Turner AA-Turner changed the title Add Python 3.14 Prepare for Python 3.14 support Aug 15, 2025
@woodruffw
Copy link
Member

No issue at all!

@woodruffw
Copy link
Member

Ah, I under-thought this a bit -- this needs to first have the list primed, and then we'll do a follow-up PR to add 3.14 to the list of Python versions on the actual library side.

@AA-Turner
Copy link
Contributor Author

@woodruffw can you take over the branch? I'm confused by what changes are needed and in what order, it seems rather complex.

@woodruffw
Copy link
Member

@woodruffw can you take over the branch? I'm confused by what changes are needed and in what order, it seems rather complex.

Yep, doing 🙂 -- I only had to remove one line, which will need a follow-up PR once the CI generates the 3.14 list.

@woodruffw
Copy link
Member

Thanks @AA-Turner!

@woodruffw woodruffw merged commit c84d14e into pypi:main Aug 15, 2025
10 checks passed
@AA-Turner
Copy link
Contributor Author

Wonderful, thank you @woodruffw. I had hoped to side-step the complexity by including the generated file in the PR, but clearly no such luck to be had!

A

@AA-Turner AA-Turner deleted the py314 branch August 15, 2025 03:51
@woodruffw
Copy link
Member

Wonderful, thank you @woodruffw. I had hoped to side-step the complexity by including the generated file in the PR, but clearly no such luck to be had!

Yeah, turns out that's 100% my bad...I thought the list generation would do this gracefully in CI, but based on how #168 failed initially I was wrong about that 😅

Sorry for the extra steps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants