Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to use ytfzf as yt-search #33

Merged
merged 3 commits into from
Feb 24, 2021
Merged

Add flag to use ytfzf as yt-search #33

merged 3 commits into from
Feb 24, 2021

Conversation

JojiiOfficial
Copy link
Contributor

@JojiiOfficial JojiiOfficial commented Feb 24, 2021

Added a new flag -L to use ytfzf as search tool, the youtube URL of the selected link will be printed out to stdout. I didn't go through all of the code so I may have missed something.

Edit: This doesn't work together with downloading thumbnails.

@JojiiOfficial
Copy link
Contributor Author

Should work now

@pystardust
Copy link
Owner

pystardust commented Feb 24, 2021

@JojiiOfficial instead of the last commit. Make thumbnail flag=0 in the start itself if the option U is given. That would be much cleaner what do you thing?

@JojiiOfficial
Copy link
Contributor Author

Yep you're right!

@JojiiOfficial
Copy link
Contributor Author

Nvm, then you don't see the thumbnails when you select the video

@pystardust
Copy link
Owner

Hey, I just understood what you meant in the first solution.
But there is one more problem. There will be "." comming from download meter we will need to account for that also. I am currently occupied, Ill get to it in a half a day.

@JojiiOfficial
Copy link
Contributor Author

No hurries. There are (should be) no more '.' coming from the thumbnail download meter.

@pystardust
Copy link
Owner

Let, us do it in a way, such that both the thumbails and urls work together. Lets rework that part comletely ig. One option could to be to completely remove the dots and the downloading thumbs that is being printed.

@JojiiOfficial
Copy link
Contributor Author

JojiiOfficial commented Feb 24, 2021

That is exactly the way how it's working right now :)
Look at this part

Edit: Nvm I'm mistaken, it worked but apparently I executed the wrong script. I agree with reworking this part, although I have no idea how you're expecting it to be nor am I a good bash scripter

@JojiiOfficial
Copy link
Contributor Author

I (hopefully) fixed it. Generally a -q (quiet) option would be nice. This could be set automatically on -L to prevent the output.

@pystardust
Copy link
Owner

@JojiiOfficial Nice work. Im merging this. Ill clean the if statemets into one liners using &&'s
btw its posix not bash 😆

@pystardust pystardust merged commit 8d93c38 into pystardust:master Feb 24, 2021
pystardust added a commit that referenced this pull request Feb 25, 2021
Add flag to use ytfzf as yt-search
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants