Skip to content

gh-133590: Initialize TableEntry.linenumber_borrow. #133681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ljfp
Copy link

@ljfp ljfp commented May 8, 2025

Since the author decided to initialize filename_borrow to NULL, I think that linenumber_borrow should also be initialized (likely to 0).

In its current state it could become an issue in the report_leak() function if for some reason entry->linenumber_borrow = linenumber; fails to be executed and then linenumber_borrow is accessed when filename_borrow is non-NULL. I'm not sure if this code path is possible at all, but initializing linenumber_borrow shouldn't have any side-effects.

If this was left intentionally uninitialized for some reason, it would be a good idea to close this PR and open another one documenting the motive behind leaving it like this.

Also, stackrefs.c had a blank line at the beginning of the file (!!); I took the liberty to remove it.

@python-cla-bot
Copy link

python-cla-bot bot commented May 8, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

bedevere-app bot commented May 8, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented May 8, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@ljfp ljfp changed the title gh-133590: Initialize TableEntry.linenumber_borrow to 0. gh-133590: Initialize TableEntry.linenumber_borrow. May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant