gh-133590: ensure that TableEntry.linenumber_borrow is initialized
#133681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
ljfp
changed the title
picnixz
approved these changes
May 9, 2025
Misc/NEWS.d/next/Core_and_Builtins/2025-05-08-18-21-59.gh-issue-133590.jsmXkD.rst
Outdated
Show resolved
Hide resolved
picnixz
changed the title
TableEntry.linenumber_borrow is initialized
|
CI seems stuck. I'll close/reopen your PR. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 11, 2025
…lized (pythonGH-133681) (cherry picked from commit c838e21) Co-authored-by: Lauta <[email protected]>
|
GH-133872 is a backport of this pull request to the 3.14 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the author decided to initialize
filename_borrowto NULL, I think thatlinenumber_borrowshould also be initialized (likely to 0).In its current state it could become an issue in the report_leak() function if for some reason
entry->linenumber_borrow = linenumber;fails to be executed and then linenumber_borrow is accessed when filename_borrow is non-NULL. I'm not sure if this code path is possible at all, but initializing linenumber_borrow shouldn't have any side-effects.If this was left intentionally uninitialized for some reason, it would be a good idea to close this PR and open another one documenting the motive behind leaving it like this.
Also, stackrefs.c had a blank line at the beginning of the file (!!); I took the liberty to remove it.
linenumber_borrowfield of theTableEntrystruct #133590