gh-69528: Distinguish between file modes wb+ and rb+
#137834
Open
+27
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
____ Co-authored-by: Xiang Zhang <[email protected]>
There was a problem hiding this comment.
This is not what I meant.
Open a file in the "wb+" mode and pass it to GzipFile instead of a filename. Check that that GzipFile is writable and not readable. You can also do the same for "rb+" and other modes. Most likely there are already such tests for "rb" and "wb" (and maybe for "ab" and "xb"?).
Do you want that in this PR, or another one? |
Misc/NEWS.d/next/Core_and_Builtins/2025-08-15-20-35-30.gh-issue-69528.qc-Eh_.rst
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.