-
-
Notifications
You must be signed in to change notification settings - Fork 867
Dynamically substitute main version in versions.rst from release-cycle.json #1583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamically substitute main version in versions.rst from release-cycle.json #1583
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable to me. Leaving it to our release expert @hugovk 👋 to review and merge. Thanks @corneliusroemer for working on improvements to the devguide too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A couple of suggestions.
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Thanks for the suggestions @hugovk - I have accepted them and added a small additional fix (renaming |
Co-authored-by: Ezio Melotti <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
In #1582 @hugovk suggested programmatically setting the version of the main branch to avoid having to do it manually each year:
This is an attempt to do so generated in conjunction with openai's codex.
It introduces the first non-purely-declarative code into conf.py. Maybe there's a better place to put the code but I'm not familiar with the code base.
This screenshot shows that things work as expected (tested on commit 6da61e3)
https://cpython-devguide--1583.org.readthedocs.build/versions/
📚 Documentation preview 📚: https://cpython-devguide--1583.org.readthedocs.build/