Skip to content

Remove outdated whitespace checks from patchcheck list #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jun 26, 2025

The whitespace checks are now part of pre-commit and not patchcheck:

make patchcheck
...
Checked 114 modules (35 built-in, 79 shared, 0 n/a on macosx-15.5-arm64, 0 disabled, 0 missing, 0 failed on import)
./python.exe -E ./Tools/build/generate-build-details.py `cat pybuilddir.txt`/build-details.json
./python.exe ./Tools/patchcheck/patchcheck.py
Getting base branch for PR ... upstream/main
Getting the list of files that have been added/changed ... 13 files
Docs modified ... yes
Misc/ACKS updated ... NO
Misc/NEWS.d updated with `blurb` ... yes
configure regenerated ... not needed
pyconfig.h.in regenerated ... not needed

Did you run the test suite and check for refleaks?

📚 Documentation preview 📚: https://cpython-devguide--1592.org.readthedocs.build/

Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Ezio Melotti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants