Skip to content

Ignore overload impl when checking __OP__ and __rOP__ compatibility #18502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

Ignore overload impl when checking __OP__ and __rOP__ compatibility #18502

merged 1 commit into from
Jun 20, 2025

Conversation

sterliakov
Copy link
Collaborator

Fixes #18498

@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@sterliakov sterliakov marked this pull request as ready for review January 21, 2025 22:49
ilevkivskyi
ilevkivskyi approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a simple flag would have been sufficient, but likely there is not much difference in performance anyway.

@ilevkivskyi ilevkivskyi merged commit 0c26253 into python:master Jun 20, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Different overlap checking between __mul__ and __rmul__
2 participants
@sterliakov @ilevkivskyi